- status_monitor: add availability_managed set; _monitor_loop skips devices
in this set so the LWT/availability topic is the sole online/offline source
- device_manager: register device with status_monitor.set_availability_managed()
so the monitor actually skips them (previously the monitor had no knowledge
of DeviceManager.availability_managed)
- mqtt_bridge: remove blanket 'reset all devices to offline' on bridge restart;
this was causing a race condition where the cron reset state AFTER the bridge
had already sent device_online events via retained MQTT messages;
stale running session cleanup is kept (still needed)
- direct_session devices now use availability_topic (LWT) exclusively
for online/offline state - timeout monitor no longer interferes
- Added availability_managed set: devices in this set bypass
update_last_seen() and are ignored by the timeout monitor
- Added heartbeat_topics set: heartbeat messages return early before
the session parser, eliminating direct_session_missing_fields warnings
- Added mark_online_silent() to DeviceStatusMonitor: updates state
without emitting a duplicate device_online event
- registry.py: added availability_topic + status_topic params for
direct_session parser type
- server.py: set last_config_update from file mtime on load_persisted_config
- mqtt_bridge.py: auto push config + reset device states when bridge
comes back from offline (prevents stale state in Odoo after restart)
When _process_event raised a DB exception (e.g. constraint violation),
PostgreSQL put the whole transaction into ABORTED state. Any subsequent
ORM call (event.mark_processed, Odoo's own flush) then raised
psycopg2.errors.InFailedSqlTransaction, masking the real error.
Fix: wrap _process_event in a database savepoint inside receive_iot_event.
A processing failure now only rolls back the session/device side-effects;
the ows.iot.event record stays committed and the error is stored in
processing_error. The transaction itself remains valid for Odoo's flush.
NameError: name 'fields' is not defined (ab 20:12 Uhr in den Logs)
Ursache: iot_api.py ist ein Controller, kein Model – 'fields' war
niemals importiert. Der UTC-Fix verwendete fälschlicherweise
fields.Datetime.to_datetime() und fields.Datetime.to_string().
Fix:
- 'fields' und 'timedelta' zu den top-level Imports ergänzt
- fields.Datetime.to_datetime(event.timestamp) → event.timestamp
(ORM-Datetime-Felder sind im Controller bereits datetime-Objekte)
- fields.Datetime.to_string(dt) → dt.strftime('%Y-%m-%d %H:%M:%S')
- Inline 'from datetime import timedelta as _td' entfernt
_logger.info('msg', session_id=...) ist structlog-Syntax.
Python-Standard-Logger wirft dabei TypeError → Odoo rollback →
session_complete-Events wurden niemals committed und landeten
in der Bridge-Retry-Queue (Endlosschleife).
Fix: Auf _logger.info('msg %s %s', val1, val2)-Format umgestellt.
Problem: Lasercutter-Sessions wurden in get_pos_session_suggestions
übersprungen, weil start_time > end_time.
Bug 1 – iot_api.py (session_complete):
session_start_time im Gerät-Payload ist Lokalzeit ohne TZ-Info.
Bisher naiv als UTC gespeichert → start_time lag 1h nach end_time.
Fix: start_time = end_time - session_seconds (komplett UTC-basiert).
session_start_time aus dem Payload wird nicht mehr verwendet.
Bug 2 – machine_time_control_button.js:
toServerDatetime(new Date()) verwendete getHours() (Lokalzeit).
Odoo erwartet UTC-Strings → attendanceEnd war 1h zu groß.
Fix: Auf getUTCHours() / getUTCDate() etc. umgestellt.
session_config wird nicht mehr über die API/YAML gesendet.
parser_config ist jetzt das einzige Config-Format zwischen Odoo und Bridge.
Änderungen:
- api/models.py: DeviceConfig.session_config → parser_config: dict
SessionConfig bleibt als internes Modell für SessionDetector
DeviceConfig.to_session_config() extrahiert Werte mit Defaults
- config/schema.py: DeviceConfig gleich umgestellt + to_session_config()
- config/loader.py: liest parser_config aus YAML, Fallback für legacy
session_config (Rückwärtskompatibilität für bestehende config-active.yaml)
- core/device_manager.py: device.session_config → device.to_session_config()
- core/service_manager.py: session_config Referenzen entfernt
- Odoo _build_bridge_config: sendet parser_config direkt (+ heartbeat)
- Odoo iot_api.py: gleich umgestellt
- Tests: alle SessionConfig-Fixtures → parser_config dicts
63/63 passing
write() rief _build_bridge_config() auf bevor der ORM-Cache
geleert war – self.search() las noch die alten (gecachten) Werte.
Resultat: parser_type-Änderung wurde in die config-active.yaml
nicht übernommen.
Fix: flush_all() + invalidate_all() vor dem Push erzwingt,
dass _build_bridge_config() die soeben geschriebenen Werte liest.
Der vorherige Fix war falsch: 'nur bei leerem Feld befüllen' führt
dazu, dass nach shelly_pm → dummy → shelly_pm die dummy-Config übrig
bleibt. Jeder Parser hat eigene Parameter, eine fremde Config ist
für den neuen Parser wertlos.
Korrekt: Typwechsel = immer frische Defaults des neuen Parsers.
Bisher wurden bei jedem parser_type-Wechsel die Registry-Defaults
überschrieben – angepasste Werte gingen verloren.
Neu: Defaults werden nur eingetragen wenn parser_config leer ('{}')
ist, z. B. bei neu angelegten Geräten oder nach manuellem Leeren.
Das ace-Widget erwartet einen String, aber fields.Json liefert ein
Python-Dict zurück. JS ruft .toString() darauf auf → '[object Object]'.
Änderungen:
- mqtt_device.py: fields.Json → fields.Text(default='{}')
- _onchange_parser_type: json.dumps(defaults, indent=2) statt dict
- get_parser_config_dict: json.loads() mit Fehlerbehandlung
- iot_api.py: json.loads(device.parser_config or '{}')
- DB: parser_config jsonb → text (USING parser_config::text)
Demonstriert den vollständigen Ablauf für einen neuen Parser mit
ANDEREN Parametern als shelly_pm (Flat Wide Table, Bridge SoT).
Bridge (iot_bridge):
- parsers/dummy_parser.py: Komplett neu – liest 'pulses' (int) statt
'value', gibt apower=float(pulses) für SessionDetector zurück
- parsers/registry.py: dummy_generic-Parameter ersetzt:
standby_threshold_w/working_threshold_w → pulse_count, pulse_debounce_ms,
reset_interval_min (je mit odoo_field-Mapping)
Odoo (open_workshop_mqtt):
- mqtt_device.py: 3 neue Felder dummy_pulse_count, dummy_pulse_debounce_ms,
dummy_reset_interval_min (Flat Wide Table, NULL für andere Parser)
- mqtt_device.py: _compute_strategy_config depends + elif für dummy_generic
erzeugt jetzt pulse-spezifischen JSON-Config-Dict
- mqtt_device.py: _onchange_parser_type setzt Puls-Defaults statt
shelly-Schwellenwerte
- mqtt_device_views.xml: invisible-Bedingungen auf parser_type not in [...]
umgestellt (korrekt skalierend bei 3+ Parsern)
- mqtt_device_views.xml: Inline-Hint-Divs aus Leistungs-Schwellenwerte
entfernt (unnötig)
- mqtt_device_views.xml: Neue Gruppe '🔢 Puls-Konfiguration' mit 3 Feldern
DB: 3 neue Spalten in ows_mqtt_device angelegt (odoo -u Erfolg)
Tests: 63/63 grün
- mqtt_device.py: _PARSER_SELECTION-Konstante eingeführt; tasmota und
generic entfernt (hatten keine Bridge-Implementierung); depends in
_compute_strategy_config um parser_type erweitert; _onchange nutzt
jetzt topic_hint aus Registry (<device>/status/pm1:0)
- mqtt_device_views.xml: Parser-spezifischer Info-Block für shelly_pm
(topic_hint, Beschreibung) mit invisible='parser_type != shelly_pm'
- Bestehende DB-Geräte: alle 3 bereits auf shelly_pm → keine Migration
- GET /parsers: läuft und liefert vollständige Schema-Antwort
- Include device_status_timeout_s in Odoo bridge payload
- Resolve status monitor timeout robustly with backward-compatible fallbacks
- Update running status monitor timeout on POST /config without restart
- Keep compatibility for legacy/local configs without device_status_timeout_s
Result: shaperorigin uses configured 90s timeout for online/offline monitor, preventing 30s flapping.
Problem: Device Status Monitor was using a hardcoded 30-second global timeout
for marking devices offline, independent of the configurable message_timeout_s.
This caused alternating offline/online events for devices with power=0 that
don't send frequent MQTT messages.
Solution: Use the same timeout value (message_timeout_s) for both:
1. Session Detection (message_timeout_s)
2. Device Status Monitoring (device_status_timeout_s)
Implementation:
- Add device_status_timeout_s field to api/models.py DeviceConfig (default: 120s)
- Update Odoo iot_api.py to include device_status_timeout_s in config response
(synchronized with message_timeout_s from device strategy config)
- Update Bridge service_manager.py to use device_status_timeout_s when
initializing DeviceStatusMonitor (fallback to global config if not provided)
Result:
- Single configurable timeout per device in Odoo
- Both checks (session + device status) use same value
- Backward compatible (defaults to 120s if not provided)
- Solves alternating offline/online events for low-power/idle devices
Validation:
- mypy: 0 errors across 47 files
- API model test: device_status_timeout_s field functional
Features:
- Added ows.mqtt.bridge model with health status monitoring
- Bridge list/form views with status indicators (Online/Offline/Unknown)
- Scheduled action for periodic health checks (every 2 minutes)
- Health metrics: devices count, subscriptions, last seen timestamp
- Manual health check button in UI
- Smart button linking brokers to bridge instance
Infrastructure:
- Added ows.mqtt.broker model for MQTT broker configurations
- Bridge-Broker relation via Many2one field
- Dynamic MQTT reconnection without container restart
- Robust startup: Bridge starts even when MQTT fails
- TLS reconfiguration limitation documented (paho-mqtt)
Technical Changes:
- Updated models to use @api.model_create_multi for Odoo 18
- Fixed view definitions: tree → list for Odoo 18 compatibility
- Removed mail.thread dependency (unnecessary chatter)
- Added ir.cron for automated health monitoring
- Security/ACL rules for bridge and broker models
- Menu integration under IoT/MQTT section
Documentation:
- Updated IMPLEMENTATION_PLAN.md with new features
- Updated Odoo module README with bridge/broker models
- iot_bridge/README.md already documents dynamic reconnection
Testing:
- All changes tested via Odoo module upgrade
- Health check endpoint verified: GET /health
- Bridge reconnection tested with broker config changes
BREAKING CHANGE: Renamed models for consistent naming convention
- mqtt.device → ows.mqtt.device (table: ows_mqtt_device)
- mqtt.session → ows.mqtt.session (table: ows_mqtt_session)
- ows.iot.event unchanged (table: ows_iot_event)
Changes:
- Updated all Many2one/One2many relations to use new model names
- Updated all env references in controllers and tests
- Updated security CSV file with new model IDs
- Updated all view records (list/form/kanban/pivot/graph/search)
- Fixed controller reference that was still using old mqtt.session
Documentation:
- Added README.md for user-facing module documentation
- Regenerated API.md from updated docstrings
- Regenerated index.html from README.md
Cleanup:
- Removed debug/test files (check_routes.py, test-*.sh/txt)
- Removed obsolete python_proto_type directory
Note: This requires database migration or fresh setup.
Database was reset and module reinstalled successfully.
E2E test with Shelly Simulator passed.
- Implement build script (build_docs.py) with AST parser to auto-generate HTML docs from docstrings
- Add comprehensive Google-style docstrings to all controllers and models
- Create static/description/index.html for Odoo Apps UI with module overview
- Generate api_reference.html (20.5 KB) from source code, linked from Odoo UI
- Add DOCUMENTATION_STRATEGY.md with comparison of 5 documentation approaches
- Create API.md with complete REST API documentation
Device Status Monitoring:
- Implement device_status_monitor.py with health checks and offline detection
- Add /status endpoint for device health overview
- Automatic offline detection after message_timeout_s
Config Push Architecture:
- Add POST /config endpoint to IoT Bridge for dynamic device management
- Auto-push device config from Odoo on create/write/unlink
- Implement device_manager.py for runtime device updates
E2E Tests:
- All 6 E2E tests passing (Create, Update, Push, Delete, Restart, Status Monitor)
- Test coverage for device lifecycle and config synchronization
Documentation is auto-generated via: ./build_docs.sh
View in Odoo: Settings → Apps → Open Workshop MQTT → API Reference
Major architectural improvements to make Bridge resilient:
1. Bridge Autonomy (CRITICAL FIX):
- Remove sys.exit(1) when Odoo config fails (iot_bridge/main.py)
- Bridge now runs autonomously with local config.yaml
- No longer crashes in endless restart loop when Odoo is down
- Odoo connection check becomes optional warning, not blocker
2. Event Type Compatibility:
- Add 'session_ended' to controller event processing (iot_api.py)
- Bridge sends 'session_ended', controller expected 'session_stopped'
- Now accepts both event types for closing sessions
3. Event Type Support:
- Add 'session_ended' to iot_event model selection (iot_event.py)
- Fixes 500 errors when Bridge sends session_ended events
4. Architecture Documentation:
- Update FEATURE_REQUEST with new PUSH architecture (Odoo -> Bridge)
- Update IMPLEMENTATION_PLAN with Phase 3 refactoring plan
- Document autonomous mode and config-push design
- Remove obsolete documentation files
Tested Scenarios:
- ✅ Bridge starts and runs without Odoo
- ✅ Session detection works autonomously
- ✅ Events queue when Odoo is down
- ✅ Queue automatically processes when Odoo returns
- ✅ Sessions close correctly with session_ended events
This enables the next phase: Odoo pushing config to Bridge via HTTP API.
